Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Migration developer): Added account picker and button from SDK s… #17137

Merged
merged 3 commits into from
May 9, 2024

Conversation

nbaenam
Copy link
Contributor

@nbaenam nbaenam commented Apr 30, 2024

Migration of the SDK component library docs from the developer site to the docs site.

This is the ticket: NR-261819

@nbaenam nbaenam added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Apr 30, 2024
@nbaenam nbaenam self-assigned this Apr 30, 2024
Copy link

Hi @nbaenam 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 93b2d35
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/663b7de26af629000842d97f
😎 Deploy Preview https://deploy-preview-17137--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nbaenam nbaenam moved this from Hero to triage to In progress in Docs PRs and Issues Apr 30, 2024
@paperclypse paperclypse marked this pull request as draft April 30, 2024 15:40
@paperclypse
Copy link
Contributor

@nbaenam I converted this to a draft, because it seems incomplete

@homelessbirds homelessbirds moved this from In progress to Drafts in Docs PRs and Issues May 2, 2024
@paperclypse
Copy link
Contributor

paperclypse commented May 2, 2024

@nbaenam I think you should merge in the work that you've completed here, but please delete the unfinished placeholders before merging in. After a PR approval, of course.

@nbaenam nbaenam removed the request for review from jeff-colucci May 8, 2024 18:49
@nbaenam nbaenam moved this from Drafts to Needs review in Docs PRs and Issues May 8, 2024
@nbaenam nbaenam marked this pull request as ready for review May 8, 2024 18:49
@github-actions github-actions bot requested a review from rhetoric101 May 8, 2024 18:50
@rhetoric101 rhetoric101 removed their request for review May 8, 2024 20:12
Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@nbaenam nbaenam merged commit 78d2e8c into develop May 9, 2024
18 checks passed
@nbaenam nbaenam deleted the nb-sdk-component-NR-261819 branch May 9, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants