Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nerdgraph): changing markdown tables to html #17191

Merged
merged 4 commits into from
May 8, 2024

Conversation

homelessbirds
Copy link
Contributor

There was a request to add a line to one of these tables in the help-doc channel. I noticed the tables were in markdown. Converted them and added the line.

@homelessbirds homelessbirds self-assigned this May 3, 2024
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Hi @homelessbirds 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented May 3, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 759d795
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6638fdb1bcf11f000817b8e7
😎 Deploy Preview https://deploy-preview-17191--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@homelessbirds homelessbirds moved this from Hero to triage to In progress in Docs PRs and Issues May 3, 2024
Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@homelessbirds take a look at my suggestions and see what you think.

@homelessbirds
Copy link
Contributor Author

Approved by @rhetoric101

@homelessbirds homelessbirds merged commit ebbe1d2 into develop May 8, 2024
17 checks passed
@homelessbirds homelessbirds deleted the sd-dashboards-fixing-table branch May 8, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants