Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Docs): Cleaned up part of the nav #17200

Merged
merged 3 commits into from
May 10, 2024
Merged

fix(Docs): Cleaned up part of the nav #17200

merged 3 commits into from
May 10, 2024

Conversation

paperclypse
Copy link
Contributor

@nbaenam I thought we should clean up the nav a little bit. In general, I think we want to avoid too much nav sprawl. Also the quotation marks in the nav title seemed to be causing problems.

@paperclypse paperclypse added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels May 6, 2024
@paperclypse paperclypse requested a review from nbaenam May 6, 2024 15:39
@paperclypse paperclypse self-assigned this May 6, 2024
@github-actions github-actions bot requested a review from rhetoric101 May 6, 2024 15:39
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Hi @paperclypse 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented May 6, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 148edfb
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/663d2f715a25620008080e34
😎 Deploy Preview https://deploy-preview-17200--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akristen akristen moved this from Hero to triage to In progress in Docs PRs and Issues May 6, 2024
nbaenam
nbaenam previously approved these changes May 8, 2024
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a small suggestion! Feel free to take it or leave it🙂

path: /docs/new-relic-solutions/tutorials/build-react-hooks-app
- title: Build demo apps
pages:
- title: Build your own demo app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title is too different from the one on the page. Maybe, you could change one of them.
Build your own demo app <> New Relic apps: build your own New Relic experiences

@nbaenam nbaenam self-requested a review May 10, 2024 14:30
@paperclypse paperclypse merged commit ab85794 into develop May 10, 2024
17 checks passed
@paperclypse paperclypse deleted the nav-clean-up branch May 10, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants