update: add CyberArk REST API details #17205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be documented since the CyberArk REST API returns a JSON payload with `UserName` for username and `Content` for password. See code here for mapping: https://github.com/newrelic/infrastructure-agent/blob/master/pkg/databind/internal/secrets/cyberarkapi.go#L45-L50
|
|
|
Hi @pnvnd 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
akristen
added
content
removed callout since it's not necessary (and would get lost with the other tips surrounding it), and fixed typo
akristen
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be documented since the CyberArk REST API returns a JSON payload with
UserNamefor username andContentfor password.See code here for mapping:
https://github.com/newrelic/infrastructure-agent/blob/master/pkg/databind/internal/secrets/cyberarkapi.go#L45-L50
** What problems does this PR solve?**
Helps document the correct
usernameandpasswordvariable to use CyberArk REST API for credentials.Add any context that will help us review your changes such as testing notes, links to related docs, screenshots, etc.
Using the CyberArk REST API, you get a JSON payload that included
UserNameandContentwhich would be natural to use in the credential variable, which is not that case since the Infrastructure Agent is mapping them tousernameandpasswordinstead.N/A