always link to /whats-new/feed.xml #17222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyzanchi
requested review from
clarkmcadoo and
LizBaker
and removed request for
a team
|
Hi @sunnyzanchi 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
github-actions
bot
added
the
eng
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
i18n versions of this page were linking to /<locale>/whats-new/feed.xml, which doesn't exist, as the RSS feed isn't translated. this change makes sure we always properly link to the RSS feed
sunnyzanchi
force-pushed
the
sunny/fix-i18n-rss-links
branch
from
3502e94
to
be46998
Compare
|
still getting the 404 on this page - https://deploy-preview-17222--docs-website-netlify.netlify.app/es/whats-new/ |
clarkmcadoo
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18n versions of this page were linking to
/<locale>/whats-new/feed.xml, which doesn't exist, as the RSS feed isn't translated. this change makes sure we always properly link to the RSS feed