Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonarqube-monitoring-integration.mdx #17252

Merged
merged 1 commit into from
May 10, 2024

Conversation

alaiavee
Copy link
Contributor

@alaiavee alaiavee commented May 9, 2024

Examples were specifying the wrong files (host connection files instead of metric collection files) as the COLLECTION_FILES.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
    Fixes errors in the provided examples.

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
    In the jmx host connection files, the COLLECTION_FILES parameter needs to specify a metrics collection file. The examples were incorrectly specifying the jmx-sonarqube-compute-engine-config.yml host connection file under COLLECTION_FILES instead.

  • If your issue relates to an existing GitHub issue, please link to it.
    N/A, but related to forum topic: LINK

Examples were specifying the wrong files (host connection files instead of metric collection files) as the COLLECTION_FILES.
@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented May 9, 2024

Hi @alaiavee 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues May 9, 2024
Copy link

netlify bot commented May 9, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit d16b036
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/663d0d65c17ab9000800c750
😎 Deploy Preview https://deploy-preview-17252--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akristen
Copy link
Contributor

akristen commented May 9, 2024

Hi @alaiavee ! Can you sign our CLA? Thanks!

@akristen akristen self-assigned this May 9, 2024
@akristen akristen added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels May 9, 2024
@akristen akristen moved this from Hero to triage to In review in Docs PRs and Issues May 9, 2024
@akristen akristen moved this from In review to Waiting on SME/Blocked in Docs PRs and Issues May 9, 2024
@akristen akristen merged commit c35af0e into newrelic:develop May 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Waiting on SME/Blocked
Development

Successfully merging this pull request may close these issues.

None yet

3 participants