-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontmatter style guide fixes #17394
Conversation
Hi @austin-schaefer 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/content/docs/style-guide/writing-docs/processes-procedures/frontmatter-page-templates.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/style-guide/writing-docs/processes-procedures/frontmatter-page-templates.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I reviewed the frontmatter doc and it built fine, tables rendered correctly, and the copy is good. Some nitpicky things, but overall i think it's good to merge as is :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a typo. Other than that it's perfect!
Reviewer: Please focus on the "Frontmatter and page templates" doc, the rest of this is just sweep work. I want to ensure the changed doc is helpful and accurate for writers