Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Docs): Next batch of developer migration (AB test app 1) #17407

Merged
merged 7 commits into from
May 24, 2024

Conversation

paperclypse
Copy link
Contributor

@paperclypse paperclypse commented May 22, 2024

Tickets addressed by this PR:
NR-264657
NR-264920
NR-964922

@paperclypse paperclypse added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels May 22, 2024
@paperclypse paperclypse self-assigned this May 22, 2024
@paperclypse paperclypse requested a review from nbaenam May 22, 2024 16:43
Copy link

Hi @paperclypse 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 52e67a2
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66509b16afbd210008513658
😎 Deploy Preview https://deploy-preview-17407--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paperclypse paperclypse marked this pull request as draft May 22, 2024 20:29
@ally-sassman ally-sassman moved this from Hero to triage to Drafts in Docs PRs and Issues May 22, 2024
nbaenam
nbaenam previously approved these changes May 23, 2024
@paperclypse paperclypse marked this pull request as ready for review May 23, 2024 17:21
nbaenam
nbaenam previously approved these changes May 24, 2024
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, mostly about following our style guide. Feel free to take them or leave them🙂

@paperclypse paperclypse merged commit d66424e into develop May 24, 2024
18 of 19 checks passed
@paperclypse paperclypse deleted the migrate-ab-test-app-developer-site branch May 24, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants