Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Change title #17545

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Prometheus: Change title #17545

merged 1 commit into from
Jun 5, 2024

Conversation

rhetoric101
Copy link
Contributor

Clarify that this integration is for host monitoring (per SME).

@rhetoric101 rhetoric101 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jun 5, 2024
@rhetoric101 rhetoric101 self-assigned this Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Hi @rhetoric101 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 5, 2024
@github-actions github-actions bot requested a review from nbaenam June 5, 2024 01:39
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 84a0bc7
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/665fc1d62074300008595b89
😎 Deploy Preview https://deploy-preview-17545--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rhetoric101 rhetoric101 moved this from Hero to triage to Needs review in Docs PRs and Issues Jun 5, 2024
@rhetoric101 rhetoric101 moved this from Needs review to In review in Docs PRs and Issues Jun 5, 2024
@rhetoric101 rhetoric101 moved this from In review to Needs review in Docs PRs and Issues Jun 5, 2024
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, although the nav title is Node Exporter and we should try to keep the consistency between nav titles and doc titles.

@nbaenam nbaenam moved this from Needs review to Waiting on TW to merge in Docs PRs and Issues Jun 5, 2024
@rhetoric101
Copy link
Contributor Author

@nbaenam good point! Still, in this case, we're just adding this to help search engine optimization. I think it'll be OK to keep the shorter version in the left navigation because the longer version would be difficult to scan in the list.

@rhetoric101 rhetoric101 merged commit ef9a1c7 into develop Jun 5, 2024
29 checks passed
@rhetoric101 rhetoric101 deleted the rhs-clarify-node-exporter branch June 5, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Development

Successfully merging this pull request may close these issues.

None yet

2 participants