Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some SCIM and SAML fixes #2633

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Some SCIM and SAML fixes #2633

merged 2 commits into from
Jun 9, 2021

Conversation

zuluecho9
Copy link
Contributor

@zuluecho9 zuluecho9 commented Jun 9, 2021

Assorted fixes for user mgmt liaisonship. Work related to DOC-6834. I wouldn't spend much time thinking about the phrasing/readability, honestly; these docs are pretty messy and convoluted and have quite a few issues in this regard. Focused on just making them accurate for now.

@zuluecho9 zuluecho9 added content requests related to docs site content pg_CAP from_tw Identifies issues/PRs from Tech Docs writers labels Jun 9, 2021
@github-actions github-actions bot added this to Needs Triage in Docs PRs and Issues Jun 9, 2021
@zuluecho9 zuluecho9 moved this from Needs Triage to Any TW: Writer needs PR review in Docs PRs and Issues Jun 9, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 9, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 14m

@barbnewrelic barbnewrelic self-requested a review June 9, 2021 21:10
@barbnewrelic barbnewrelic self-assigned this Jun 9, 2021
@barbnewrelic barbnewrelic moved this from Any TW: Writer needs PR review to In review (Hero or any TW) in Docs PRs and Issues Jun 9, 2021
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted 2 questions in one of these six docs. As far as I could tell, everything else is fine. OK to merge after you take a look and fix as applicable, no need for another review. Thanks for all your hard work on this!

@barbnewrelic barbnewrelic moved this from In review (Hero or any TW) to Any TW: Needs peer edit in Docs PRs and Issues Jun 9, 2021
@barbnewrelic barbnewrelic moved this from Any TW: Needs peer edit to Waiting on TW to merge in Docs PRs and Issues Jun 9, 2021
@zuluecho9 zuluecho9 merged commit e1b47f7 into develop Jun 9, 2021
@zuluecho9 zuluecho9 deleted the Some-SCIM-doc-fixes branch June 9, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Development

Successfully merging this pull request may close these issues.

None yet

2 participants