Create check for out of date translated files #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 11m |
aswanson-nr
previously approved these changes
Jun 17, 2021
aswanson-nr
reviewed
Jun 17, 2021
zstix
reviewed
Jun 17, 2021
zstix
reviewed
Jun 17, 2021
zstix
previously approved these changes
Jun 21, 2021
aswanson-nr
previously approved these changes
Jun 21, 2021
zstix
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a workflow job which will add a required check on PRs to develop and main.
The check will find translated files that don't have an english counterpart, for instance: if an english file is deleted, any translations for the file should also be deleted.
Instead of deleting the files via the workflow we decided to make a failable check which will remind contributors to clean up any translated files that should no longer exist.
TODO:
Closes #2323