-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update workflow & job names #2751
Conversation
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 13m |
@jpvajda feedback came from @paperclypse to frame most of the checks as questions. @paperclypse if you are good with john's suggestions, I can make those changes. |
@nr-kkenney Thanks for clarifying I'd prefer we follow a declarative approach and just name the jobs as statements as using questions in programming isn't common. cc @paperclypse |
@nr-kkenney I haven't heard back from @paperclypse but I want to move this forward, so let's go with my suggested edits as this is a more declarative approach. |
* updated names based on pr comments. * also updated steps which enable branch protection to use the new names for checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jpvajda Just because something isn't common, doesn't mean it shouldn't be done :) But I think it's fine in this case. Anything is an improvement over what we had, basically. Thanks! |
Resolves: #2613