Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workflow & job names #2751

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

moonlight-komorebi
Copy link
Contributor

@moonlight-komorebi moonlight-komorebi commented Jun 18, 2021

  • updated workflow & job names to better describe what is happening, and better indicate if a particular check can be ignored.

Resolves: #2613

@github-actions github-actions bot added this to Needs Triage in Docs PRs and Issues Jun 18, 2021
@moonlight-komorebi moonlight-komorebi marked this pull request as ready for review June 18, 2021 00:26
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 18, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 13m

.github/workflows/pr-triage.yml Outdated Show resolved Hide resolved
.github/workflows/pr-triage.yml Outdated Show resolved Hide resolved
.github/workflows/update-whats-new-ids.yml Outdated Show resolved Hide resolved
.github/workflows/validate-pr.yml Outdated Show resolved Hide resolved
.github/workflows/validate-pr.yml Outdated Show resolved Hide resolved
.github/workflows/validate-pr.yml Outdated Show resolved Hide resolved
@moonlight-komorebi
Copy link
Contributor Author

@jpvajda feedback came from @paperclypse to frame most of the checks as questions. @paperclypse if you are good with john's suggestions, I can make those changes.

@jpvajda
Copy link

jpvajda commented Jun 21, 2021

@nr-kkenney Thanks for clarifying I'd prefer we follow a declarative approach and just name the jobs as statements as using questions in programming isn't common. cc @paperclypse

@jpvajda
Copy link

jpvajda commented Jun 21, 2021

@nr-kkenney I haven't heard back from @paperclypse but I want to move this forward, so let's go with my suggested edits as this is a more declarative approach.

* updated names based on pr comments.
* also updated steps which enable branch protection to use the new
names for checks.
Copy link

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moonlight-komorebi moonlight-komorebi merged commit 6bd1e8d into develop Jun 21, 2021
@moonlight-komorebi moonlight-komorebi deleted the 2613_update_github_names branch June 21, 2021 21:18
@paperclypse
Copy link
Contributor

@jpvajda Just because something isn't common, doesn't mean it shouldn't be done :) But I think it's fine in this case. Anything is an improvement over what we had, basically. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Docs PRs and Issues
Hero to triage
Development

Successfully merging this pull request may close these issues.

Improve GitHub check names so that it's easier to understand what they execute
3 participants