Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handful of old permissions callouts for DOC-6138 #2938

Merged
merged 2 commits into from Jul 2, 2021

Conversation

austin-schaefer
Copy link
Collaborator

@austin-schaefer austin-schaefer commented Jul 2, 2021

Doc-6138 asks for an audit of remaining permissions callouts.

@github-actions github-actions bot added this to Needs Triage in Docs PRs and Issues Jul 2, 2021
@austin-schaefer austin-schaefer marked this pull request as draft July 2, 2021 05:39
@austin-schaefer
Copy link
Collaborator Author

austin-schaefer commented Jul 2, 2021

This regex turned up a few more:

image

@austin-schaefer austin-schaefer added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jul 2, 2021
@austin-schaefer austin-schaefer marked this pull request as ready for review July 2, 2021 05:46
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 2, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 14m

@x8a x8a moved this from Needs Triage to Any TW: Needs peer edit in Docs PRs and Issues Jul 2, 2021
@zuluecho9 zuluecho9 moved this from Any TW: Needs peer edit to Waiting on SME/Blocked in Docs PRs and Issues Jul 2, 2021
@zuluecho9 zuluecho9 moved this from Waiting on SME/Blocked to In review (Hero or any TW) in Docs PRs and Issues Jul 2, 2021
@zuluecho9 zuluecho9 self-requested a review July 2, 2021 14:10
@zuluecho9
Copy link
Contributor

This looks good, I didn't even know we still had these in docs, so good catch. This made me realize we have a lot of 'Account settings UI' mentions still in docs, and that's a v1 model UI page, so I'm creating a jira to take a look at those.

@zuluecho9 zuluecho9 moved this from In review (Hero or any TW) to Any TW: Needs peer edit in Docs PRs and Issues Jul 2, 2021
@zuluecho9 zuluecho9 moved this from Any TW: Needs peer edit to Waiting on TW to merge in Docs PRs and Issues Jul 2, 2021
@austin-schaefer austin-schaefer merged commit 08e8595 into develop Jul 2, 2021
@austin-schaefer austin-schaefer deleted the DOC-6138-permissions-callout branch July 2, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Development

Successfully merging this pull request may close these issues.

None yet

2 participants