Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure agent - Update docker discovery snippet #3517

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Infrastructure agent - Update docker discovery snippet #3517

merged 1 commit into from
Aug 17, 2021

Conversation

brushknight
Copy link
Contributor

Usually we will have ${discovery.private.ip} and only if public ip attached to container we could use ${discovery.ip}.

Give us some context

  • What problems does this PR solve?
  • Update documentation

Usually we will have ${discovery.private.ip} and only if public ip attached to container we could use ${discovery.ip}.
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Aug 17, 2021
Copy link
Contributor

@dbarnesbrownNR dbarnesbrownNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@dbarnesbrownNR dbarnesbrownNR merged commit 846dee4 into newrelic:develop Aug 17, 2021
@dbarnesbrownNR dbarnesbrownNR added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Hero to triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants