Apply same nav logic to file nodes #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 40m |
urbiz-nr
added
the
eng
3 tasks
zuluecho9
previously approved these changes
Aug 19, 2021
|
Zach reviewed this, seems good. I'll be rewriting our internal style guide docs (which Clinton touched here) in a little bit so will give those closer review later... |
roadlittledawn
changed the title
|
@zuluecho9 is going to remove dummy doc files as part of this work, because they should no longer be needed with this code update. |
|
@zuluecho9 removal of dummy docs and links in nav LGTM. going to merge this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies same nav logic to file nodes as auto index pages to try to determine the "true nav" for a page that has a link in more than one nav YAML file.
Related issues / PRs
Closes #3559
Screenshot(s)
See the left nav for this page in prod, vs in preview below: