Fix legacy-style data dictionary links #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-schaefer
added
content
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 15m |
.../docs/infrastructure/infrastructure-ui-pages/infrastructure-ui/infrastructure-hosts-page.mdx
Outdated
Show resolved
Hide resolved
...nfrastructure-troubleshooting/troubleshoot-infrastructure/no-data-appears-infrastructure.mdx
Show resolved
Hide resolved
...e/install-infrastructure-agent/configuration/infrastructure-agent-configuration-settings.mdx
Outdated
Show resolved
Hide resolved
...infrastructure-agent/linux-installation/docker-instrumentation-infrastructure-monitoring.mdx
Outdated
Show resolved
Hide resolved
.../new-relic-infrastructure/infrastructure-alert-conditions/alert-infrastructure-processes.mdx
Outdated
Show resolved
Hide resolved
...ons/kubernetes-integration/get-started/kubernetes-integration-compatibility-requirements.mdx
Outdated
Show resolved
Hide resolved
...w-relic-one/use-new-relic-one/ui-data/new-relic-feature-end-life-announcements-july-2020.mdx
Outdated
Show resolved
Hide resolved
stumblefiend
suggested changes
Aug 24, 2021
| @@ -467,7 +467,7 @@ Use the following properties to enable or disable attributes: | |||
|
|
|||
| Prefix of attributes to exclude from error collection. Allows `*` as wildcard at end. | |||
|
|
|||
| To prevent [error.message](https://docs.newrelic.com/attribute-dictionary?attribute_name=error.message) collection, instead use the [strip_exception_messages](https://docs.newrelic.com/docs/agents/ruby-agent/configuration/ruby-agent-configuration#strip_exception_messages-enabled) configuration. | |||
| To prevent [error.message](/attribute-dictionary?attribute_name=error.message) collection, instead use the [strip_exception_messages](https://docs.newrelic.com/docs/agents/ruby-agent/configuration/ruby-agent-configuration#strip_exception_messages-enabled) configuration. | |||
There was a problem hiding this comment.
another relative link here
| @@ -79,7 +79,7 @@ The `BrowserInteraction` and `PageView` events end their reporting when they rec | |||
| </td> | |||
|
|
|||
| <td> | |||
| This new metric, available with [agent version 1163](https://docs.newrelic.com/docs/release-notes/new-relic-browser-release-notes/browser-agent-release-notes/browser-agent-v1163), [`largestContentfulPaint`](https://docs.newrelic.com/attribute-dictionary/pageviewtiming/largestcontentfulpaint), reports the render time of the largest content element visible in the viewport. Google's research found looking at when the largest element was rendered was a more accurate way to measure when the main content of a page is loaded and useful. Details on this metric, including limitations and considerations can be found in the [w3c draft](https://wicg.github.io/largest-contentful-paint/). | |||
| This new metric, available with [agent version 1163](https://docs.newrelic.com/docs/release-notes/new-relic-browser-release-notes/browser-agent-release-notes/browser-agent-v1163), [`largestContentfulPaint`](/attribute-dictionary/pageviewtiming/largestcontentfulpaint), reports the render time of the largest content element visible in the viewport. Google's research found looking at when the largest element was rendered was a more accurate way to measure when the main content of a page is loaded and useful. Details on this metric, including limitations and considerations can be found in the [w3c draft](https://wicg.github.io/largest-contentful-paint/). | |||
| @@ -29,7 +29,7 @@ Data should appear in the Infrastructure monitoring UI within a few minutes for | |||
| </Callout> | |||
|
|
|||
| <Callout variant="important"> | |||
| By default, the infrastructure agent doesn't send [data about the operating system's processes](https://docs.newrelic.com/attribute-dictionary?attribute_name=&events_tids%5B%5D=8412). To enable the sending of process data set [`enable_process_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#enable-process-metrics) to `true`. To fine-tune which processes you want to monitor, configure [`include_matching_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#include-matching-metrics). | |||
| By default, the infrastructure agent doesn't send data about the operating system's processes. To enable the sending of process data set [`enable_process_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#enable-process-metrics) to `true`. To fine-tune which processes you want to monitor, configure [`include_matching_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#include-matching-metrics). | |||
| @@ -267,7 +267,7 @@ Here are some of the things you can do from the **Network** tab: | |||
| ## Processes tab | |||
|
|
|||
| <Callout variant="important"> | |||
| By default, the infrastructure agent doesn't send [data about the operating system's processes](https://docs.newrelic.com/attribute-dictionary?attribute_name=&events_tids%5B%5D=8412). To enable the sending of process data set [`enable_process_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#enable-process-metrics) to `true`. To fine-tune which processes you want to monitor, configure [`include_matching_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#include-matching-metrics). | |||
| By default, the infrastructure agent doesn't send [data about the operating system's processes](/attribute-dictionary/?event=ProcessSample) unless you use guided install. To enable the sending of process data set [`enable_process_metrics`](/docs/infrastructure/install-infrastructure-agent/configuration/infrastructure-agent-configuration-settings/) to `true`. To fine-tune which processes you want to monitor, configure [`include_matching_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#include-matching-metrics). | |||
| @@ -19,7 +19,7 @@ Use New Relic infrastructure's **Process running** [alert condition](/docs/infra | |||
| This feature's flexibility allows you to easily filter what hosts and processes to monitor and when to notify selected individuals or teams. In addition, the email notification includes links to help you quickly troubleshoot the situation. | |||
|
|
|||
| <Callout variant="important"> | |||
| By default, the infrastructure agent doesn't send [data about the operating system's processes](https://docs.newrelic.com/attribute-dictionary?attribute_name=&events_tids%5B%5D=8412). To enable the sending of process data set [`enable_process_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#enable-process-metrics) to `true`. To fine-tune which processes you want to monitor, configure [`include_matching_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#include-matching-metrics). | |||
| By default, the infrastructure agent doesn't send [data about the operating system's processes](/attribute-dictionary/?event=ProcessSample). To enable the sending of process data set [`enable_process_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#enable-process-metrics) to `true`. To fine-tune which processes you want to monitor, configure [`include_matching_metrics`](https://docs.newrelic.com/docs/infrastructure/install-configure-manage-infrastructure/configuration/infrastructure-configuration-settings#include-matching-metrics). | |||
| @@ -116,7 +116,7 @@ The New Relic Kubernetes integration has the following requirements: | |||
| * A New Relic account. Don't have one? [Sign up for free](https://newrelic.com/signup). No credit card required. | |||
| * Linux distribution [compatible with New Relic infrastructure agent](/docs/infrastructure/new-relic-infrastructure/getting-started/compatibility-requirements-new-relic-infrastructure#operating-systems). | |||
| * [`kube-state-metrics` version 1.9.8](https://github.com/kubernetes/kube-state-metrics) running on the cluster. | |||
| * When using CRI-O as the container runtime, the [processes](https://docs.newrelic.com/attribute-dictionary?attribute_name=&events_tids%5B%5D=8412) inside containers are not reported. Performance data is collected at the [container](https://docs.newrelic.com/docs/integrations/kubernetes-integration/understand-use-data/find-use-your-kubernetes-data#container-data) level. | |||
| * When using CRI-O as the container runtime, the [processes](/attribute-dictionary/?event=ProcessSample) inside containers are not reported. Performance data is collected at the [container](https://docs.newrelic.com/docs/integrations/kubernetes-integration/understand-use-data/find-use-your-kubernetes-data#container-data) level. | |||
There was a problem hiding this comment.
I know some of these links weren't part of your sweep, but should they be made relative too?
There was a problem hiding this comment.
I'm inclined to not block on making the other links relative, there are around ~2000 absolute links on the site that probably "should" be relative links and I feel like it's a pretty bottomless rabbithole.
stumblefiend
approved these changes
Aug 24, 2021
rhetoric101
moved this from Hero to triage
to In progress/being reviewed (by Hero or any TW)
in Docs PRs and Issues
|
Ended up merging w/o fixing all relative links, there are about ~2000 absolute links on the docs site that "should" be relative and I'm not inclined to go too far down that rabbithole. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing remaining legacy-style data dictionary links from the site. Checked a bunch of links in Gatsby Cloud and all seem fine.