Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing redirect for alerts #3645

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Add missing redirect for alerts #3645

merged 3 commits into from
Aug 25, 2021

Conversation

bradleycamacho
Copy link
Contributor

This was a hero request to fix a broken 404. Looks like we had a missing redirect.

@bradleycamacho bradleycamacho added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Aug 25, 2021
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Aug 25, 2021
@bradleycamacho bradleycamacho moved this from Hero to triage to Drafts in Docs PRs and Issues Aug 25, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 25, 2021 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 17m

@zuluecho9
Copy link
Contributor

zuluecho9 commented Aug 25, 2021 •
edited

I'd recommend seeing that original slack channel convo, as I think there are some weird things going on with this doc. I was actually this morning trying to figure out what was going on. Earlier today this doc's URL was added to its own list of redirects, which is part of problem probably. And that non-loading URL you could find in swifttype files, so that was probably why it showed up in docs search. Some weird ghosts in the system.

@bradleycamacho
Copy link
Contributor Author

@zuluecho9 Good eye, I got a bit spooked when I saw the sheer amount of redirects.

@bradleycamacho bradleycamacho mentioned this pull request Aug 25, 2021
Closed
@bradleycamacho
Copy link
Contributor Author

Closes #3640 once merged.

@bradleycamacho bradleycamacho marked this pull request as ready for review August 25, 2021 20:05
@github-actions github-actions bot requested a review from urbiz-nr August 25, 2021 20:05
@bradleycamacho
Copy link
Contributor Author

The PR now adds a redirect from the url that appears in the search results. It also removes a circular redirect.

@zuluecho9 zuluecho9 requested review from zuluecho9 and removed request for urbiz-nr August 25, 2021 20:09
zuluecho9
zuluecho9 previously approved these changes Aug 25, 2021
View reviewed changes
@bradleycamacho bradleycamacho marked this pull request as draft August 25, 2021 21:22
@bradleycamacho bradleycamacho marked this pull request as ready for review August 25, 2021 21:22
@github-actions github-actions bot requested a review from x8a August 25, 2021 21:23
@bradleycamacho bradleycamacho removed the request for review from x8a August 25, 2021 21:23
Docs PRs and Issues automation moved this from Drafts to Hero to triage Aug 25, 2021
@bradleycamacho bradleycamacho merged commit bf6692b into develop Aug 25, 2021
@bradleycamacho bradleycamacho deleted the alerts-redirects branch August 25, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuluecho9 zuluecho9 zuluecho9 left review comments

Assignees
No one assigned
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Hero to triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bradleycamacho @zuluecho9