Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow and deny list examples for remote write #3769

Merged
merged 2 commits into from Sep 2, 2021

Conversation

davidchock
Copy link
Contributor

Examples include Prometheus standalone and Prometheus on Kubernetes using a specific Helm chart. Also brings out a caveat of other helm charts

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

Are you making a change to site code?

If you're changing site code (rather than the content of a doc), please follow
conventional commit standards
in your commit messages and pull request title.

Examples include Prometheus standalone and Prometheus on Kubernetes using a specific Helm chart. Also brings out a caveat of other helm charts
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Sep 2, 2021
@paperclypse paperclypse added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Sep 2, 2021
@paperclypse paperclypse self-assigned this Sep 2, 2021
@paperclypse paperclypse moved this from Hero to triage to Hero: To do in Docs PRs and Issues Sep 2, 2021
@paperclypse
Copy link
Contributor

Hi @davidchock! Thanks for helping out. Please be sure to sign the Contributor License Agreement.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 2, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 42m

@paperclypse paperclypse moved this from Hero: To do to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Sep 2, 2021
@paperclypse paperclypse self-requested a review September 2, 2021 21:20
Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@paperclypse paperclypse moved this from In progress/being reviewed (by Hero or any TW) to Waiting on TW to merge in Docs PRs and Issues Sep 2, 2021
@paperclypse paperclypse merged commit 3547938 into newrelic:develop Sep 2, 2021
@urbiz-nr urbiz-nr removed this from Waiting on TW to merge in Docs PRs and Issues Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants