Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updating gatsby-plugin-mdx #3868

Merged
merged 1 commit into from Sep 13, 2021
Merged

chore: updating gatsby-plugin-mdx #3868

merged 1 commit into from Sep 13, 2021

Conversation

rudouglas
Copy link
Contributor

No description provided.

@rudouglas rudouglas added deven services eng issues related to site functionality that requires engineering labels Sep 10, 2021
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Sep 10, 2021
@rudouglas rudouglas removed this from Hero to triage in Docs PRs and Issues Sep 10, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 10, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 30m

@rudouglas rudouglas linked an issue Sep 12, 2021 that may be closed by this pull request
Update gatsby-plugin-mdx #3538
Closed
3 tasks
aswanson-nr
aswanson-nr approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the preview and everything is looking good!

roadlittledawn
roadlittledawn approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@roadlittledawn roadlittledawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also checked the following:

MDX serialization / deserialization tests passed

Spot checked a couple HTML strings in doc .json endpoints and no obvious issues.

Spot checked several release note RSS feed items with HTML and no obvious issues.

Looks like these two plugins are still necessary:

  • gatsby-remark-mdx-v2-fenced-code-blocks
  • gatsby-remark-mdx-v2-images

@aswanson-nr aswanson-nr merged commit cf64828 into develop Sep 13, 2021
@aswanson-nr aswanson-nr deleted the ru/update-mdx branch September 13, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roadlittledawn roadlittledawn roadlittledawn approved these changes

@aswanson-nr aswanson-nr aswanson-nr approved these changes

Assignees
No one assigned
Labels
eng issues related to site functionality that requires engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update gatsby-plugin-mdx
3 participants
@rudouglas @roadlittledawn @aswanson-nr