Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ruby agent configuration documentation for 8.0 release #4026

Conversation

kaylareopelle
Copy link
Contributor

Give us some context

  • What problems does this PR solve?
    The configuration documentation needed further updates for the Ruby Agent's 8.0 release.

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.

  • If your issue relates to an existing GitHub issue, please link to it.
    Relates to the recently merged PR: Ruby Agent 8.0.0 release updates #4019

Are you making a change to site code?

No.

If you're changing site code (rather than the content of a doc), please follow
conventional commit standards
in your commit messages and pull request title.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Sep 22, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 22, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 30m

@barbnewrelic barbnewrelic self-assigned this Sep 22, 2021
@barbnewrelic barbnewrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) pg_UXP labels Sep 22, 2021
@barbnewrelic barbnewrelic moved this from Hero to triage to Hero: To do in Docs PRs and Issues Sep 22, 2021
@kaylareopelle
Copy link
Contributor Author

we just noticed an issue during our internal review. standby!

@kaylareopelle
Copy link
Contributor Author

Fix has been made and pushed! Maybe the build will work this time 🤞

@barbnewrelic barbnewrelic moved this from Hero: To do to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Sep 22, 2021
@barbnewrelic
Copy link
Contributor

@kaylareopelle Can you please take a look at line 1205? It was originally enclosed in a single backtick and I thought that might be the problem, so I changed it to three backticks. But that didn't work either. Asked a couple of folks on my team and they think that entire block of text enclosed in backtick might be too much for a row in a table to handle. Maybe you could edit it down into something meaningful to readers but not so long? Thanks!

@barbnewrelic barbnewrelic moved this from In progress/being reviewed (by Hero or any TW) to Writer needs peer edit (Hero or any TW can take) in Docs PRs and Issues Sep 23, 2021
@barbnewrelic barbnewrelic moved this from Writer needs peer edit (Hero or any TW can take) to Waiting on SME/Blocked in Docs PRs and Issues Sep 23, 2021
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tracking down the blocker!

@barbnewrelic barbnewrelic merged commit 43bc023 into newrelic:develop Sep 23, 2021
@kaylareopelle
Copy link
Contributor Author

Thanks for your patience, persistence and support!

Your hunch was right -- that long line had some issues. It used the triple backticks for a code block instead of the one-liner code snippet syntax. That didn't play well with the <td>.

@barbnewrelic barbnewrelic moved this from Waiting on SME/Blocked to Waiting on TW to merge in Docs PRs and Issues Sep 23, 2021
@kaylareopelle kaylareopelle deleted the ruby-agent/8-0-0-release-config-updates branch April 18, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Waiting on TW to merge
Development

Successfully merging this pull request may close these issues.

None yet

2 participants