Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logs intro: fix attribute name restrictions #4084

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Update logs intro: fix attribute name restrictions #4084

merged 2 commits into from
Sep 28, 2021

Conversation

bmcfeely
Copy link
Contributor

Howdy from the Logging Team! Just noticed something that needs updating: the Log ingestion pipeline allows appId, but eventType gets dropped.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

Are you making a change to site code?

If you're changing site code (rather than the content of a doc), please follow
conventional commit standards
in your commit messages and pull request title.

We allow `appId`, and `eventType` gets dropped.
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Sep 28, 2021
@barbnewrelic barbnewrelic self-assigned this Sep 28, 2021
@barbnewrelic barbnewrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) pg_TDP labels Sep 28, 2021
@barbnewrelic barbnewrelic moved this from Hero to triage to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Sep 28, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 28, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 29m

Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the build, looks great! Thanks for updating this doc!

@barbnewrelic barbnewrelic merged commit 950cd23 into newrelic:develop Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants