Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alerts): Replaced old image about signals #4184

Merged
merged 1 commit into from
Oct 5, 2021
Merged

fix(alerts): Replaced old image about signals #4184

merged 1 commit into from
Oct 5, 2021

Conversation

rhetoric101
Copy link
Contributor

This was a documentation channel request about replacing a screen shot.

I narrowed the screenshot and modified the caption.

@rhetoric101 rhetoric101 added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 5, 2021
@rhetoric101 rhetoric101 self-assigned this Oct 5, 2021
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Oct 5, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 5, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 31m

@dbarnesbrownNR dbarnesbrownNR moved this from Hero to triage to Drafts in Docs PRs and Issues Oct 5, 2021
@rhetoric101 rhetoric101 marked this pull request as ready for review October 5, 2021 19:05
@rhetoric101 rhetoric101 moved this from Drafts to Writer needs PR review (Hero or any TW can take) in Docs PRs and Issues Oct 5, 2021
@rhetoric101 rhetoric101 marked this pull request as draft October 5, 2021 21:33
@rhetoric101 rhetoric101 marked this pull request as ready for review October 5, 2021 21:33
@rhetoric101 rhetoric101 added from_tw Identifies issues/PRs from Tech Docs writers and removed from_internal Identifies issues/PRs from Relics (except writers) labels Oct 5, 2021
@rhetoric101 rhetoric101 marked this pull request as draft October 5, 2021 23:17
@rhetoric101 rhetoric101 marked this pull request as ready for review October 5, 2021 23:17
barbnewrelic
barbnewrelic approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the screenshot. BTW that gif works great!

@barbnewrelic barbnewrelic moved this from Writer needs PR review (Hero or any TW can take) to Waiting on TW to merge in Docs PRs and Issues Oct 5, 2021
@rhetoric101 rhetoric101 merged commit 62168e8 into develop Oct 5, 2021
@rhetoric101 rhetoric101 deleted the rhs-hero-alerts-signal-settings branch October 5, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbnewrelic barbnewrelic barbnewrelic approved these changes

Assignees

@rhetoric101 rhetoric101

Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhetoric101 @barbnewrelic