Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated links #4191

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Updated links #4191

merged 1 commit into from
Oct 5, 2021

Conversation

halocameo
Copy link
Contributor

Please check other links on this page as well.

Please check other links on this page as well.
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Oct 5, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 5, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 29m

@dbarnesbrownNR
Copy link
Contributor

Hi @halocameo, thank you for these updates! However it appears all the redirects in place work for the content you edited, and we are going to be making some changes to parts of the site taxonomy this PR touches very soon. In light of that, I'm going to tentatively suggest we hold off on these changes pending confirmation from someone on the Docs team that we won't be overwriting the update with work in the pipeline for Oct release. Thanks!

@dbarnesbrownNR dbarnesbrownNR added from_internal Identifies issues/PRs from Relics (except writers) content requests related to docs site content pg_XD labels Oct 5, 2021
@dbarnesbrownNR dbarnesbrownNR self-assigned this Oct 5, 2021
@dbarnesbrownNR dbarnesbrownNR moved this from Hero to triage to Hero: To do in Docs PRs and Issues Oct 5, 2021
@dbarnesbrownNR dbarnesbrownNR moved this from Hero: To do to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Oct 5, 2021
@halocameo
Copy link
Contributor Author

Hi @dbarnesbrownNR, the redirects do not work to take the user to the right section of the page - they just redirect to the new page but not to the anchor link they should take the user to.

@dbarnesbrownNR
Copy link
Contributor

Ah, gotcha @halocameo -- in that case I get the rationale so will try to balance with other considerations. Could you do me a favor and shoot me a message over Slack so we can discuss? I can't seem to figure out your New Relic identity from your GH handle and for privacy reasons we only use handles over GH.

Copy link
Contributor

@dbarnesbrownNR dbarnesbrownNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we have accurate h2 linking in advance of larger taxonomy updates. Thanks!

@dbarnesbrownNR dbarnesbrownNR merged commit d84c679 into newrelic:develop Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants