Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Alerts): update Alerts loss-of-signal examples to use aggregationMethod #4247

Merged
merged 1 commit into from
Oct 8, 2021
Merged

fix(Alerts): update Alerts loss-of-signal examples to use aggregationMethod #4247

merged 1 commit into from
Oct 8, 2021

Conversation

founddrama
Copy link
Contributor

Give us some context

With the streaming aggregation method support rolling out this week, trying to update the NerdGraph examples that are out there to use the aggregationMethod field instead of evaluationOffset.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Oct 8, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Hi @founddrama 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 8, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 31m

rhetoric101
rhetoric101 approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@founddrama, these improvements look good!

@rhetoric101 rhetoric101 merged commit 9c10f59 into newrelic:develop Oct 8, 2021
@rhetoric101 rhetoric101 self-assigned this Oct 8, 2021
@rhetoric101 rhetoric101 added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 8, 2021
@founddrama founddrama deleted the docs/amend-loss-of-signal branch October 8, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhetoric101 rhetoric101 rhetoric101 approved these changes

Assignees

@rhetoric101 rhetoric101

Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Hero to triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@founddrama @rhetoric101