-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new fields; removed deprecated fields; clarified recommended settings #4381
Conversation
…ttings Three updates to the NRQL section: * I've added the fields that were introduced with our new [aggregation methods](https://discuss.newrelic.com/t/new-aggregation-methods-for-nrql-alert-conditions/158831), which replace the deprecated `evaluation_offset` and `since_value` fields * I've removed the deprecated fields from the example code * I've adjusted the recommended values for `aggregation_window` and `aggregation_delay` to represent they're in seconds rather than minutes, addressing @HenryTech's comment [here](newrelic#4368 (comment)) I do have a question — by linking to their glossary definitions, is it clear that you need either `aggregation_delay` _or_ `aggregation_timer` depending on which `aggregation_method` you've selected?
Hi @jeffreycs 👋 |
Well...... I've now realized that all the links to the glossary definitions are broken, likely due to a path change. I also appear to have missed an instance of |
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 15m |
Thanks @jeffreycs! I'll look it over and see what I can do to get that sorted out. |
There's an issue when linking to redirect URLs. I updated them to use the direct URL.
Hi @jeffreycs, apparently we have an issue on our site when we link to pages through a redirect URL. It drops the ID. I've updated the URLs so we're using the direct URL. Would you mind clarifying what you mean by "I also appear to have missed an instance of since_value."? Is there anything that I need to take care of there? |
I'd mistakenly left in one additional instance of a deprecated field; it is now removed
Thanks @paperclypse! What I had meant is that I accidentally left one instance of a deprecated field. I just pushed a new commit that removes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Three updates to the NRQL section:
evaluation_offset
andsince_value
fieldsaggregation_window
andaggregation_delay
to represent they're in seconds rather than minutes, addressing @HenryTech's comment hereI do have a question — by linking to their glossary definitions, is it clear that you need either
aggregation_delay
oraggregation_timer
depending on whichaggregation_method
you've selected?