Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whats new id deletion logic #4394

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add whats new id deletion logic #4394

merged 1 commit into from
Oct 19, 2021

Conversation

LizBaker
Copy link
Contributor

We have a script to generate new whats new IDs, but it didn't include any cleanup for what's new posts that get deleted.
the nr1-announcements end-point doesn't care about this because it only matches IDs to existing posts, but the nr1-announcements/ids endpoint grabs the entire ID list which includes the deleted posts. this is was causing issue in the whats new nerdlet since they rely on the /ids endpoint to know when to delete a post

@github-actions
Copy link

Hi @LizBaker 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Oct 19, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 19, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 11m

@roadlittledawn
Copy link
Collaborator

should the number of ID entries in ids.json be equal to the number of posts in nr1-announcements.json ?

i see 104 IDs and 101 posts.

@dbarnesbrownNR dbarnesbrownNR removed this from Hero to triage in Docs PRs and Issues Oct 19, 2021
@LizBaker
Copy link
Contributor Author

@roadlittledawn yes! but i figured i'd let the action run the new script and commit the changes when it does rather than myself committing them. i guess there's no difference really, should i also commit the updated whats new file?

@roadlittledawn
Copy link
Collaborator

roadlittledawn commented Oct 19, 2021

ah right because that runs later and commits to develop.

if it doesn't cause a mismatch between main and develop, sure. but maybe it's best to leave it run. though i just noticed last couple runs failed? https://github.com/newrelic/docs-website/actions/workflows/update-whats-new-ids.yml

@LizBaker
Copy link
Contributor Author

hmm interesting, looks like one was a bad install and the other was out of sync, though i'm confused about how it got that way

@LizBaker LizBaker merged commit 5554d25 into develop Oct 19, 2021
@LizBaker LizBaker deleted the liz/whats-new-cleanup branch October 19, 2021 21:00
@LizBaker LizBaker linked an issue Oct 20, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's new IDs aren't getting deleted
2 participants