-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions to list source maps via node #4514
Conversation
* Before: var listSourcemaps = require(‘@newrelic/publish-sourcemap’).listSourcemaps listSourcemaps({ sourcemapPath: 'SOURCE_MAP_FULL_PATH', javascriptUrl: 'JS_URL', applicationId: YOUR_NEW_RELIC_APP_ID, apiKey: 'YOUR_NEW_RELIC_USER_API_KEY', }, function (err, res) { console.log(err || res.body)}) * After: var listSourcemaps = require(‘@newrelic/publish-sourcemap’).listSourcemaps listSourcemaps({ applicationId: <var>YOUR_NEW_RELIC_APP_ID</var>, apiKey: '<var>YOUR_NEW_RELIC_USER_API_KEY</var>', limit: [Max number of results to return || 20]: , offset: [Number of results to skip before returning || 0]: , }, function (err, res) { console.log(err || res.body)})
Hi @afvalenciab 👋 |
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 27m |
@afvalenciab Hi Andres. Could you by chance give us a little more information on why you suggested that change? I'm trying to get some input from source map-knowledgeable people but in meantime I thought a little more detail about what you were thinking might help me/us get to the bottom of this. And thank you very much for your suggestions! |
@afvalenciab Actually, I talked to support and they approved this, so thank you much for that. |
Fix the instructions to list source maps via node, because the instructions are wrong and different to npm instrucctions.
links to related docs, screenshots, etc.
Before:
`var listSourcemaps = require(‘@newrelic/publish-sourcemap’).listSourcemaps
After:
` var listSourcemaps = require(‘@newrelic/publish-sourcemap’).listSourcemaps
Please follow conventional commit standards
in your commit messages and pull request title.
Give us some context
links to related docs, screenshots, etc.