Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: if not in frontmatter set isFeatured to false, cleanup unused code #4526

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

roadlittledawn
Copy link
Collaborator

@roadlittledawn roadlittledawn commented Oct 25, 2021

Description

Sets isFeatured frontmatter to false if not set at all in frontmatter. Relevant to What's New posts.

Additional cleanup for unused code.

Will want to let PLG know about the change since they use this field in https://docswebsitedevelop-clangwhatsnewfeaturedfix.gtsb.io/api/nr1/content/nr1-announcements.json

@github-actions
Copy link

Hi @roadlittledawn 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Oct 25, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 26, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 26m

@roadlittledawn
Copy link
Collaborator Author

pinged their hero to verify we can do this

@roadlittledawn
Copy link
Collaborator Author

PLG says good to go from their end

@roadlittledawn roadlittledawn merged commit dc92660 into develop Oct 26, 2021
@roadlittledawn roadlittledawn deleted the clang/whats-new-featured-fix branch October 26, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Docs PRs and Issues
Hero to triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants