Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style guide): Update list of video sources #4539

Merged
merged 4 commits into from Oct 26, 2021

Conversation

austin-schaefer
Copy link
Collaborator

List of places we host video was pretty outdated

@austin-schaefer austin-schaefer added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Oct 26, 2021
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Oct 26, 2021
@github-actions
Copy link

Hi @austin-schaefer 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 26, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 24m

barbnewrelic
barbnewrelic previously approved these changes Oct 26, 2021
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought somewhere in the style guide we say to include the running time if not clearly visible, but now I can't find it. Seems like that should be part of this doc so we don't have to plinko around to try to find that guideline if it still exists somewhere! :-O

@barbnewrelic barbnewrelic moved this from Hero to triage to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Oct 26, 2021
@barbnewrelic barbnewrelic moved this from In progress/being reviewed (by Hero or any TW) to Writer needs peer edit (Hero or any TW can take) in Docs PRs and Issues Oct 26, 2021
@barbnewrelic barbnewrelic moved this from Writer needs peer edit (Hero or any TW can take) to Waiting on TW to merge in Docs PRs and Issues Oct 26, 2021
Copy link
Contributor

@bradleycamacho bradleycamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, had another piece of feedback :)

Co-authored-by: Bradley Camacho <42678939+bradleycamacho@users.noreply.github.com>
@austin-schaefer austin-schaefer merged commit 3445529 into develop Oct 26, 2021
@austin-schaefer austin-schaefer deleted the austin-schaefer-patch-3 branch October 26, 2021 22:35
@urbiz-nr urbiz-nr removed this from Waiting on TW to merge in Docs PRs and Issues Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants