Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent install pages): prepped for A/B test. Added buttons. #4661

Merged
merged 3 commits into from
Nov 3, 2021
Merged

fix(agent install pages): prepped for A/B test. Added buttons. #4661

merged 3 commits into from
Nov 3, 2021

Conversation

mmfred
Copy link
Contributor

@mmfred mmfred commented Nov 2, 2021

This PR prepares a handful of agent pages for A/B tests. I used buttons consistently in these pages for new account and guided install links.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Hi @mmfred 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.
Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 2, 2021 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 28m

@urbiz-nr urbiz-nr moved this from Hero to triage to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Nov 2, 2021
@x8a x8a self-requested a review November 2, 2021 09:42
x8a
x8a reviewed Nov 2, 2021
View reviewed changes
yarn.lock
@@ -2160,11 +2160,6 @@
resolved "https://registry.yarnpkg.com/@sindresorhus/is/-/is-0.7.0.tgz#9a06f4f137ee84d7df0460c1fdb1135ffa6c50fd"
integrity sha512-ONhaKPIufzzrlNbqtWFFd+jlnemX6lJAgq9ZeiZtS7I1PIf/la7CW4m83rTXRnVnsMbW2k56pGYu7AUFJD9Pow==

"@sindresorhus/is@^2.0.0":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't commit any changes to the yarn.lock file. Could you undo the changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the yarn.lock file from develop, which is what the new changes (to 3.3.4) are on the right. This was the recommendation when the nvm upgrade started messing with that file.

x8a
x8a previously approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@x8a x8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thanks for the changes. Let's just check about the yarn.lock file.

x8a
x8a approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@x8a x8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@x8a x8a merged commit 1dbf6d8 into develop Nov 3, 2021
@x8a x8a deleted the prep-agent-docs-testing branch November 3, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x8a x8a x8a approved these changes

Assignees

@mmfred mmfred

Labels
None yet
Projects
Docs PRs and Issues
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmfred @x8a