Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify callout variants #4687

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Clarify callout variants #4687

merged 1 commit into from
Nov 3, 2021

Conversation

rhetoric101
Copy link
Contributor

Our style guide had references to classes instead of variants and those classes had the wrong values and confused contributors.

I removed the references to classes and just talked about variants.

I fixed a broken callout in alerts where a contributor had followed our style guide, which was incorrect.

@rhetoric101 rhetoric101 self-assigned this Nov 3, 2021
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Hi @rhetoric101 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.
Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@rhetoric101 rhetoric101 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Nov 3, 2021
@rhetoric101 rhetoric101 moved this from Hero to triage to Writer needs PR review (Hero or any TW can take) in Docs PRs and Issues Nov 3, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 3, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 25m

urbiz-nr
urbiz-nr approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@urbiz-nr urbiz-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating this!

@urbiz-nr urbiz-nr moved this from Writer needs PR review (Hero or any TW can take) to Waiting on TW to merge in Docs PRs and Issues Nov 3, 2021
@rhetoric101 rhetoric101 merged commit b627f78 into develop Nov 3, 2021
@rhetoric101 rhetoric101 deleted the rhs-fix-callouts-in-style-guide branch November 3, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbiz-nr urbiz-nr urbiz-nr approved these changes

Assignees

@rhetoric101 rhetoric101

Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhetoric101 @urbiz-nr