update translation testing, models #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new project_id column will help us identify which project to send translations to, and which project a job will live under. * with this information, we can use multiple projects which is how we will handle machine vs human translation -- one project for each.
moonlight-komorebi
requested review from
rudouglas and
LizBaker
and removed request for
a team
|
Hi @nr-kkenney 👋 Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
moonlight-komorebi
changed the title
4 tasks
LizBaker
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
project_idcolumn in translation and jobs tablesDid some testing to see how we could make changes to production and work with changing code in the feature branch. As long as the
project_idcolumn can be null, we can add the new columns w/o impacting the current workflows. A constraint on the column would be nice, but is more difficult to work around.Resolves: #2538