Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uvicorn.mdx #4853

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Update uvicorn.mdx #4853

merged 1 commit into from
Nov 17, 2021

Conversation

louisguitton
Copy link
Contributor

docs only change fixing a typo on this page https://docs.newrelic.com/docs/apm/agents/python-agent/web-frameworks-servers/uvicorn/

If you run the given command, you get the following error

/usr/local/bin/python: can't open file 'uvicorn': [Errno 2] No such file or directory

and indeed running the help command gives you (I have removed the irrelevant parts)

# newrelic-admin run-python --help
usage: /usr/local/bin/python [option] ... [-c cmd | -m mod | file | -] [arg] ...
-c cmd : program passed in as string (terminates option list)
file   : program read from script file

which means that newrelic-admin run-python expects a file or a -c cmd. uvicorn is not a file but a command, so I propose the follwoing fix.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Hi @louisguitton 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Nov 11, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 11, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 25m

@dbarnesbrownNR dbarnesbrownNR added content requests related to docs site content from_external Identifies issues/PRs from non-Relics pg_UXP labels Nov 11, 2021
@dbarnesbrownNR dbarnesbrownNR moved this from Hero to triage to Hero: To do in Docs PRs and Issues Nov 11, 2021
@dbarnesbrownNR dbarnesbrownNR moved this from Hero: To do to Waiting on SME/Blocked in Docs PRs and Issues Nov 12, 2021
@dbarnesbrownNR dbarnesbrownNR self-assigned this Nov 12, 2021
Copy link
Contributor

@dbarnesbrownNR dbarnesbrownNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SME approved, thank you!

@dbarnesbrownNR dbarnesbrownNR removed their assignment Nov 16, 2021
@umaannamalai
Copy link
Contributor

Approved by the Python agent engineering team. Thank you for catching this @louisguitton!

Copy link
Contributor

@dbarnesbrownNR dbarnesbrownNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and we have SME approval. All set, thanks!

@dbarnesbrownNR dbarnesbrownNR merged commit 02eb15b into newrelic:develop Nov 17, 2021
@urbiz-nr urbiz-nr removed this from Waiting on SME/Blocked in Docs PRs and Issues Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_external Identifies issues/PRs from non-Relics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants