Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add stakeholders to translation prs as reviewers #5027

Merged

Conversation

MoonlightKomorebi
Copy link
Contributor

Summary

Add Julien (stakeholder) as reviewer on translation PRs

Resolves: #3853

@MoonlightKomorebi MoonlightKomorebi requested a review from a team as a code owner November 23, 2021 21:53
@MoonlightKomorebi MoonlightKomorebi requested review from tabathadelane and josephgregoryii and removed request for a team November 23, 2021 21:53
@github-actions
Copy link

Hi @nr-kkenney 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Nov 23, 2021
@clarkmcadoo
Copy link
Contributor

@nr-kkenney, I think we talked about this for about 4 seconds, but adding a group for something like this in the future might be useful just to manage it via github instead of code changes. What do you think?

@MoonlightKomorebi
Copy link
Contributor Author

@clarkmcadoo i asked on the main ticket, but what is a group? i think I've only seen teams as a way to collect individual people, and I'm not 100% on making a new team for our org. But I'll double check.

@clarkmcadoo
Copy link
Contributor

Yeah, that's probably it. Idk, we'd probably need another ticket for it cuz we'd have to figure out who to put on that team, then actually do it.

@clarkmcadoo
Copy link
Contributor

https://github.com/orgs/newrelic/new-team makes a new team, but lets talk about this a little bit more before we do anything, it was just an idea.

@MoonlightKomorebi MoonlightKomorebi merged commit df4de85 into feature/machine-translation Nov 23, 2021
@MoonlightKomorebi MoonlightKomorebi deleted the 3853_alert_stakeholders branch November 23, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Docs PRs and Issues
Hero to triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants