Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handlebar support to code fences #5251

Merged
merged 1 commit into from Dec 10, 2021

Conversation

rhetoric101
Copy link
Contributor

This is a change that adds color formatting to handlebars code blocks in the docs.

Reviewer: to check this out, compare the middle example in the JSON collapser with the current public site: https://docs.newrelic.com/docs/alerts-applied-intelligence/notifications/message-templates/#json

@rhetoric101 rhetoric101 self-assigned this Dec 10, 2021
@rhetoric101 rhetoric101 requested a review from a team as a code owner December 10, 2021 19:32
@rhetoric101 rhetoric101 requested review from zstix and tabathadelane and removed request for a team December 10, 2021 19:32
@github-actions
Copy link

Hi @rhetoric101 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Dec 10, 2021
@rhetoric101 rhetoric101 moved this from Hero to triage to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Dec 10, 2021
@rhetoric101 rhetoric101 requested review from roadlittledawn and removed request for zstix and tabathadelane December 10, 2021 19:37
@rhetoric101 rhetoric101 added the eng issues related to site functionality that requires engineering label Dec 10, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 10, 2021

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 27m

@rhetoric101 rhetoric101 added from_external Identifies issues/PRs from non-Relics and removed eng issues related to site functionality that requires engineering labels Dec 10, 2021
@rhetoric101 rhetoric101 moved this from In progress/being reviewed (by Hero or any TW) to Writer needs PR review (Hero or any TW can take) in Docs PRs and Issues Dec 10, 2021
Copy link
Collaborator

@roadlittledawn roadlittledawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rhetoric101 rhetoric101 merged commit 5213ba2 into develop Dec 10, 2021
@rhetoric101 rhetoric101 deleted the rhs-hero-handlebars-support branch December 10, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from_external Identifies issues/PRs from non-Relics
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants