Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/update npm config options and add troubleshooting doc #5252

Merged
merged 11 commits into from Dec 13, 2021
Merged

chore/update npm config options and add troubleshooting doc #5252

merged 11 commits into from Dec 13, 2021

Conversation

thezackm
Copy link
Member

requesting review from @x8a before merging please

This PR has the following changes to NPM docs:

  • New doc created for managing the ktranslate docker container
  • New doc created for troubleshooting the health of the ktranslate docker container
  • Significant edits to the "advanced config" doc to align with current settings available in ktranslate
  • Moved several docs into new "advanced options" section in both dir and nav (this could use a watchful eye to ensure I got the redirects correct please)

@github-actions
Copy link

Hi @thezackm 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Dec 10, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 10, 2021 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 31m

@paperclypse paperclypse requested a review from x8a December 10, 2021 19:44
@barbnewrelic barbnewrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) pg_TDP labels Dec 10, 2021
@barbnewrelic barbnewrelic moved this from Hero to triage to Hero: To do in Docs PRs and Issues Dec 10, 2021
x8a
x8a previously approved these changes Dec 13, 2021
View reviewed changes
x8a
x8a previously approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@x8a x8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes, @thezackm!

@x8a x8a moved this from Hero: To do to Waiting on TW to merge in Docs PRs and Issues Dec 13, 2021
@x8a x8a merged commit bfb7d2d into newrelic:develop Dec 13, 2021
@thezackm thezackm deleted the chore/update-npm-config-options branch December 16, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x8a x8a x8a approved these changes

Assignees

@x8a x8a

Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Waiting on TW to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thezackm @x8a @barbnewrelic