Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser): fix broken link #5816

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix(browser): fix broken link #5816

merged 1 commit into from
Jan 31, 2022

Conversation

bradleycamacho
Copy link
Contributor

Closes #5813

@bradleycamacho bradleycamacho added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jan 26, 2022
@github-actions
Copy link

Hi @bradleycamacho 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jan 26, 2022
@bradleycamacho
Copy link
Contributor Author

Whoever reviews this, I'd love if you can confirm the new link is the best place to send users to.

@bradleycamacho bradleycamacho mentioned this pull request Jan 26, 2022
Closed
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jan 26, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 22m

@bradleycamacho bradleycamacho moved this from Hero to triage to Writer needs PR review (Hero or any TW can take) in Docs PRs and Issues Jan 26, 2022
urbiz-nr
urbiz-nr suggested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@urbiz-nr urbiz-nr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally, works fine.

@urbiz-nr urbiz-nr moved this from Writer needs PR review (Hero or any TW can take) to Waiting on TW to merge in Docs PRs and Issues Jan 27, 2022
@bradleycamacho bradleycamacho merged commit e66edd7 into develop Jan 31, 2022
@bradleycamacho bradleycamacho deleted the broken-spa branch January 31, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbiz-nr urbiz-nr urbiz-nr approved these changes

@rhetoric101 rhetoric101 Awaiting requested review from rhetoric101

Assignees
No one assigned
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: Use SPA API
2 participants
@bradleycamacho @urbiz-nr