Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External services fast-follow changes #5850

Merged
merged 2 commits into from
Jan 28, 2022
Merged

External services fast-follow changes #5850

merged 2 commits into from
Jan 28, 2022

Conversation

rhetoric101
Copy link
Contributor

@rhetoric101 rhetoric101 commented Jan 28, 2022 •
edited

Reviewer, could you look at the following changes?

  • In the introduction, I switched two sections around to highlight when you would use the feature.
  • In the distributed tracing planning guide, I removed a collapser that had a warning that used to apply when you would enable DT. This is no longer applicable.
  • In the limits topic, I removed an out of date comment about limit agreements for DT (per SME).

@rhetoric101 rhetoric101 added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Jan 28, 2022
@rhetoric101 rhetoric101 self-assigned this Jan 28, 2022
@github-actions
Copy link

Hi @rhetoric101 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jan 28, 2022
@rhetoric101 rhetoric101 moved this from Hero to triage to Writer needs PR review (Hero or any TW can take) in Docs PRs and Issues Jan 28, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jan 28, 2022 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 23m

@rhetoric101 rhetoric101 moved this from Writer needs PR review (Hero or any TW can take) to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Jan 28, 2022
@rhetoric101 rhetoric101 moved this from In progress/being reviewed (by Hero or any TW) to Writer needs PR review (Hero or any TW can take) in Docs PRs and Issues Jan 28, 2022
urbiz-nr
urbiz-nr approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@urbiz-nr urbiz-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tried locally. Great docs @rhetoric101!

@urbiz-nr urbiz-nr moved this from Writer needs PR review (Hero or any TW can take) to Waiting on TW to merge in Docs PRs and Issues Jan 28, 2022
@rhetoric101
Copy link
Contributor Author

@urbiz-nr, thanks for checking!

@rhetoric101 rhetoric101 merged commit 7c1c1a2 into develop Jan 28, 2022
@rhetoric101 rhetoric101 deleted the rhs-external-services-fast-follow branch January 28, 2022 22:15
@rhetoric101 rhetoric101 added from_tw Identifies issues/PRs from Tech Docs writers and removed from_internal Identifies issues/PRs from Relics (except writers) labels Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbiz-nr urbiz-nr urbiz-nr approved these changes

Assignees

@rhetoric101 rhetoric101

Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhetoric101 @urbiz-nr