fix(logs in context): attempt to clarify what LIC is #5860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuluecho9
added
content
|
Hi @zuluecho9 👋 Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
zuluecho9
moved this from Hero to triage
to In progress/being reviewed (by Hero or any TW)
in Docs PRs and Issues
barbnewrelic
previously approved these changes
Jan 28, 2022
src/content/docs/logs/logs-context/configure-logs-context-apm-agents.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/logs/logs-context/configure-logs-context-apm-agents.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/logs/logs-context/configure-logs-context-apm-agents.mdx
Show resolved
Hide resolved
src/content/docs/logs/logs-context/configure-logs-context-apm-agents.mdx
Show resolved
Hide resolved
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was related to some user type capabilities work, where we were tryin to get more clear on what user types had available, and it seemed that the 'logs in context' doc could use a little more clarity on what exactly it did for customers (e.g., that logs data appears in other areas in the UI, like APM and infra UI). The reason this was important is because there's been a lot of discussion about which user types have which functionality and we link to this doc from the user type doc. I don't have a lot of confidence in what I did (not that knowledgeable about logs or logs in context) but hope was that it would spark some more eyes on some aspects I found confusing.
Other changes:
• Some places in doc, like procedure, seemed focused mainly on APM only so I tried to make it more clear it was about APM and infra agents.
• The procedure was a little confusing to me; I made an attempt to improve it but I am still not sure how the 'enable distributed tracing' and 'see the APM agent docs' stuff is related, because the 'enable DT' doesn't seem to be mentioned in the APM-specific docs. That could probably be clearer.
• Some minor readability edits as I saw them.