Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Infinite Tracing): Update Rule Priority text for span attribute filters #5918

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

jonathanpdx
Copy link
Contributor

There was a question as to whether all or any rules needed to match for a filter to be applied. This aims to make that more clear.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?

Answers a question a real user had by clarifying how Span Attribute Filter Rules work in Infinite Tracing.

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

There was a question as to whether all or any rules needed to match for a filter to be applied. This aims to make that more clear.
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Hi @jonathanpdx 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 2, 2022
@jonathanpdx jonathanpdx changed the title Update Rule Priority for span attribute filters feat(Infinite Tracing): Update Rule Priority text for span attribute filters Feb 2, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 2, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 23m

Copy link
Contributor

@urbiz-nr urbiz-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this, @jonathanpdx!

@urbiz-nr urbiz-nr self-assigned this Feb 2, 2022
@urbiz-nr urbiz-nr added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Feb 2, 2022
@urbiz-nr urbiz-nr merged commit 75ea3b7 into newrelic:develop Feb 2, 2022
@urbiz-nr urbiz-nr removed this from Hero to triage in Docs PRs and Issues Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants