Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Parameters to Identify Destinations #6029

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

wildcardlinux
Copy link
Contributor

Line 41 currently doesnt show on Public Docs but I didnt add that line.

"Any optional key/value pairs you add in the AWS Management Console will result in attribute/value pairs you can use in New Relic."

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

Line 41 currently doesnt show on Public Docs but I didnt add that line.

"Any optional key/value pairs you add in the AWS Management Console will result in attribute/value pairs you can use in New Relic."
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Hi @wildcardlinux 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 7, 2022
@paperclypse
Copy link
Contributor

Hi @wildcardlinux, thanks for your PR! That line was added as part of PR from last week and I'm seeing it here https://docs.newrelic.com/docs/logs/forward-logs/stream-logs-using-kinesis-data-firehose/#create-delivery-stream

@paperclypse paperclypse self-assigned this Feb 7, 2022
@paperclypse paperclypse added content requests related to docs site content from_external Identifies issues/PRs from non-Relics labels Feb 7, 2022
@paperclypse paperclypse moved this from Hero to triage to Hero: To do in Docs PRs and Issues Feb 7, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 7, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 16m

Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some slight tweaks so that this matches our style guide a bit better. Otherwise, looks good!

@paperclypse paperclypse merged commit 84cb861 into newrelic:develop Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_external Identifies issues/PRs from non-Relics
Projects
Docs PRs and Issues
Scheduled work
Development

Successfully merging this pull request may close these issues.

None yet

2 participants