Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1 users): Clarifying 'claim domain' functionality for original SAML procedure #6186

Merged
merged 9 commits into from
Feb 17, 2022

Conversation

zuluecho9
Copy link
Contributor

@zuluecho9 zuluecho9 commented Feb 15, 2022

DOC-7765. Work done:
• Making it more clear how the 'claim domain' functionality works for v1 user model SAML procedure and why it's important. • Assorted readability edits

@zuluecho9 zuluecho9 self-assigned this Feb 15, 2022
@github-actions
Copy link

Hi @zuluecho9 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 15, 2022
@zuluecho9 zuluecho9 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Feb 15, 2022
@zuluecho9 zuluecho9 moved this from Hero to triage to In progress/being reviewed (by Hero or any TW) in Docs PRs and Issues Feb 15, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 16, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 16m

@zuluecho9 zuluecho9 changed the title fix(v1 users): various wording improvements fix(v1 users): Clarifying 'claim domain' functionality for original SAML procedure Feb 16, 2022
bradleycamacho
bradleycamacho previously approved these changes Feb 16, 2022
Copy link
Contributor

@bradleycamacho bradleycamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a few comments. Only other thing is: are there any decent places here to add screenshots?

…ce-providers.mdx

Co-authored-by: Bradley Camacho <42678939+bradleycamacho@users.noreply.github.com>
@zuluecho9 zuluecho9 merged commit d31dedb into develop Feb 17, 2022
@zuluecho9 zuluecho9 deleted the Clarify-v1-users-pending-aren't-billed branch February 17, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants