Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add land identifier and fix indentation #6214

Merged
merged 2 commits into from
Feb 17, 2022
Merged

docs: add land identifier and fix indentation #6214

merged 2 commits into from
Feb 17, 2022

Conversation

brnhensley
Copy link
Contributor

the code blocks were rendering incorrectly, I believe because of the indentation in the file before the triple backticks

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

the code blocks were rendering incorrectly, I believe because of the indentation in the file before the triple backticks
@github-actions
Copy link

Hi @brnhensley 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 16, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 16, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 16m

attempt #2 to fix the code formatting, it's unclear why the first line in this example is not getting it's indentation:

```cs
    async Task<string> WebEndpointExample()
    {
        var task = DoSomethingForSomeSecondsAsync(5); //kick off a 5-second-work to be done.
        
        //Do something less than 5 seconds here.
    
        await task;
        return "Complete";
    }

    [Trace]
    [MethodImpl(MethodImplOptions.NoInlining)]
    private static async Task DoSomethingForSomeSecondsAsync(int seconds)
    {
        await Task.Delay(TimeSpan.FromSeconds(seconds));
    }
```
@barbnewrelic barbnewrelic self-assigned this Feb 16, 2022
@barbnewrelic barbnewrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) pg_TDP labels Feb 16, 2022
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the code sample. Very helpful for users!

@barbnewrelic barbnewrelic moved this from Hero to triage to Hero: To do in Docs PRs and Issues Feb 16, 2022
@barbnewrelic barbnewrelic merged commit 5c0618c into newrelic:develop Feb 17, 2022
@brnhensley brnhensley deleted the patch-21 branch December 1, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Scheduled work
Development

Successfully merging this pull request may close these issues.

None yet

2 participants