Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new term - style guide - added a preferred term #6271

Merged
merged 3 commits into from
Feb 23, 2022
Merged

new term - style guide - added a preferred term #6271

merged 3 commits into from
Feb 23, 2022

Conversation

mmfred
Copy link
Contributor

@mmfred mmfred commented Feb 22, 2022

We had a request to use original in place of legacy.

@mmfred
new term - style guide - added a preferred term
4828c4b 
We had a request to use original in place of legacy.
@github-actions
Copy link

Hi @mmfred 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 22, 2022
@mmfred mmfred added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Feb 22, 2022
@paperclypse paperclypse self-assigned this Feb 22, 2022
@paperclypse paperclypse moved this from Hero to triage to Hero: To do in Docs PRs and Issues Feb 22, 2022
@mmfred
Copy link
Contributor Author

mmfred commented Feb 22, 2022

Hey folks - please don't merge. I don't see to be able to make this a draft, but can you treat it as a draft?

@mmfred mmfred moved this from Hero: To do to Drafts in Docs PRs and Issues Feb 22, 2022
@paperclypse paperclypse marked this pull request as draft February 22, 2022 23:17
@paperclypse
Copy link
Contributor

There you go, now it's a draft @mmfred :)

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 22, 2022 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 18m

@paperclypse @mmfred
fix(style guide): Remove unnecessary backticks
85140db 
Co-authored-by: mmfred <58010132+mmfred@users.noreply.github.com>
@mmfred mmfred marked this pull request as ready for review February 23, 2022 15:40
@mmfred mmfred moved this from Drafts to Hero to triage in Docs PRs and Issues Feb 23, 2022
@mmfred mmfred moved this from Hero to triage to Hero: To do in Docs PRs and Issues Feb 23, 2022
@mmfred
Copy link
Contributor Author

mmfred commented Feb 23, 2022

This is ready for review and merge if you're okay with it. Thanks!

bradleycamacho
bradleycamacho previously approved these changes Feb 23, 2022
View reviewed changes
@paperclypse paperclypse merged commit ccc5c34 into develop Feb 23, 2022
@paperclypse paperclypse deleted the mmfred-patch-1 branch February 23, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradleycamacho bradleycamacho bradleycamacho approved these changes

Assignees

@paperclypse paperclypse

Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Scheduled work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmfred @paperclypse @bradleycamacho