Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code owner changes and team reference update #6676

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Code owner changes and team reference update #6676

merged 4 commits into from
Mar 22, 2022

Conversation

josephgregoryii
Copy link
Contributor

@josephgregoryii josephgregoryii commented Mar 18, 2022 •
edited

Summary

Github:

Repo

  • Update CODEOWNERS file
  • Remove references to Developer Enablement and updated to Docs Engineering

Slightly blocked by #6566 to update the CONTRIBUTING.md with the correct slack channel

@josephgregoryii josephgregoryii requested a review from a team as a code owner March 18, 2022 20:54
@josephgregoryii josephgregoryii requested review from roadlittledawn and clarkmcadoo and removed request for a team March 18, 2022 20:54
@github-actions
Copy link

Hi @josephgregoryii 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Mar 18, 2022
@josephgregoryii josephgregoryii self-assigned this Mar 18, 2022
@josephgregoryii josephgregoryii removed this from Hero to triage in Docs PRs and Issues Mar 18, 2022
@josephgregoryii josephgregoryii linked an issue Mar 18, 2022 that may be closed by this pull request
[Docs Eng] Setup Github Public for team #6562
Closed
5 tasks
josephgregoryii
josephgregoryii commented Mar 18, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 18, 2022 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 18m

tabathadelane
tabathadelane approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@tabathadelane tabathadelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josephgregoryii josephgregoryii merged commit 9596a0f into develop Mar 22, 2022
@josephgregoryii josephgregoryii deleted the joe/codeowners branch March 22, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabathadelane tabathadelane tabathadelane approved these changes

@roadlittledawn roadlittledawn Awaiting requested review from roadlittledawn roadlittledawn was automatically assigned from newrelic/developer-enablement

@clarkmcadoo clarkmcadoo Awaiting requested review from clarkmcadoo clarkmcadoo was automatically assigned from newrelic/developer-enablement

Assignees

@josephgregoryii josephgregoryii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs Eng] Setup Github Public for team
2 participants
@josephgregoryii @tabathadelane