-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new circleci guide (DOC-7895) #7107
Conversation
Hi @jcountsNR 👋 Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 22m |
The person assigned to this Jira work will review and update this draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few style edits
|
||
4. In the sidebar of your Project Settings, click **Webhooks**. | ||
|
||
5. Click **Add Webhook**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5. Click **Add Webhook**. | |
5. Click **Add webhook**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are CircleCI UI things. I have to trust that they're capitalized correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is an interesting situation! Our style guide says we use sentence case and bold for UI elements, even if the UI element is in a different case in the UI
, but maybe that should only apply to our product and not when we reference other products?
|
||
6. Name your webhook. | ||
|
||
7. Enter New Relic's **Logs Endpoint**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7. Enter New Relic's **Logs Endpoint**: | |
7. Enter New Relic's **Logs endpoint**: |
|
||
8. Select either **Workflow** or **Job**, depending on the type of event you want to trigger the logpush. | ||
|
||
9. If you've set up your receiving API or third-party service, click **Test Ping Event** to create a test event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9. If you've set up your receiving API or third-party service, click **Test Ping Event** to create a test event. | |
9. If you've set up your receiving API or third-party service, click **Test ping event** to create a test event. |
Co-authored-by: Bradley Camacho <42678939+bradleycamacho@users.noreply.github.com>
This reverts commit 556ba0e.
@bradleycamacho I'm not going to commit your changes, because these are CircleCI UI procedures and I'm assuming that they're capitalized correctly. |
@paperclypse happy to defer to you on this, just want to ensure you saw that one comment above!
|
@bradleycamacho In this case, I think we want to prioritize trying to get this published today and then circle back later, if necessary. |
Just to add to this, the CircleCI doc link is here, I made the casing the same as the casing they used on their site. I don't have any insight as to whether our casing style should supersede theirs or not. |
@jcountsNR I wanted to make sure we got this into the afternoon release. We can go back and edit the casing later, if need be. |
New guide for circleci/new relic integration.
IMPORTANT: I need help from the dev team to decide where this lives both in the repo and in the website as a whole.
A lot of the template I used came from the existing cloudflare doc since this is a very similar page, only for CircleCI.
The guide covers 2 main areas: