Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(k8s): Fix a malformed code block #7976

Merged
merged 3 commits into from
Jun 20, 2022
Merged

chore(k8s): Fix a malformed code block #7976

merged 3 commits into from
Jun 20, 2022

Conversation

austin-schaefer
Copy link
Collaborator

Hey @x8a , this area of the k8s doc seems like it has a code formatting issue. I think this is a fix for this, but I'd love your eyes on it as someone who knows the docs and domain better than me.

This is the issue (in the OpenShift section of https://docs.newrelic.com/docs/kubernetes-pixie/kubernetes-integration/installation/kubernetes-integration-install-configure ):

image

@austin-schaefer austin-schaefer added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jun 9, 2022
@austin-schaefer austin-schaefer requested a review from x8a June 9, 2022 15:57
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Hi @austin-schaefer 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 9, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 9, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 23m

@zuluecho9 zuluecho9 moved this from Hero to triage to In progress in Docs PRs and Issues Jun 9, 2022
@zuluecho9 zuluecho9 moved this from In progress to In review in Docs PRs and Issues Jun 9, 2022
@x8a
Copy link
Contributor

x8a commented Jun 10, 2022

@austin-schaefer, thanks for the edit! I did a minor correction because I think that's how the steps should look like. I'll check with the k8 team!

x8a
x8a previously approved these changes Jun 10, 2022
kang-makes
kang-makes previously approved these changes Jun 10, 2022
@x8a x8a dismissed stale reviews from kang-makes and themself via 2fb3864 June 10, 2022 10:57
@x8a
Copy link
Contributor

x8a commented Jun 10, 2022

After checking with @kang-makes, we want to wait until some other people give us their opinion on the steps.

@x8a x8a moved this from In review to Waiting on SME/Blocked in Docs PRs and Issues Jun 10, 2022
@x8a x8a merged commit f71abe9 into develop Jun 20, 2022
@x8a x8a deleted the austin-schaefer-patch-4 branch June 20, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on SME/Blocked
Development

Successfully merging this pull request may close these issues.

None yet

3 participants