Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang logs in context (ETA 06-29-22) #8073

Merged
merged 6 commits into from Jun 29, 2022
Merged

golang logs in context (ETA 06-29-22) #8073

merged 6 commits into from Jun 29, 2022

Conversation

iamemilio
Copy link
Contributor

@iamemilio iamemilio commented Jun 16, 2022 •
edited by barbnewrelic

Docs hero: @barbnewrelic will take care of this one when ready to release!

feat: logs in context for golang

this adds documentation for logs in context for the go agent. Please merge this in synchronization with the go team's release of the logs in context feature

For additional context about the zerolog plugin, see the readme here: https://github.com/newrelic/go-agent/blob/2e6700e93818bef216c81635ffc4a0d0d801242f/v3/integrations/logcontext-v2/nrzerolog/Readme.md

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 16, 2022
@github-actions
Copy link

Hi @iamemilio 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 16, 2022 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 22m

@barbnewrelic barbnewrelic moved this from Hero to triage to Drafts in Docs PRs and Issues Jun 16, 2022
@barbnewrelic
Copy link
Contributor

@iamemilio Thanks for letting us know! Do you have an ETA for when Go will release automatic logs in context or what release version that will be available? Please @ mention me (I'm currently logs docs liaison) whenever your team is ready, and I will sync together these doc releases. No rush!

@barbnewrelic barbnewrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Jun 16, 2022
@barbnewrelic barbnewrelic self-assigned this Jun 16, 2022
@iamemilio
Copy link
Contributor Author

@barbnewrelic we are targeting the end of June for a full release, but that release date is currently at risk until I clear up some issues in the code. I will coordinate with you as soon as we are confident about a release date, and follow up the week of the release so there are no surprises.

@iamemilio iamemilio marked this pull request as ready for review June 21, 2022 18:03
@iamemilio
Copy link
Contributor Author

@barbnewrelic We are aiming to release next Monday!

@rhetoric101 rhetoric101 moved this from Drafts to Scheduled work in Docs PRs and Issues Jun 21, 2022
@rhetoric101 rhetoric101 changed the title golang logs in context golang logs in context (Publish on Monday, June 27th) Jun 21, 2022
@iamemilio
feat(logs in context for go): add new documents
0104a14
@iamemilio
feat(go dt by default): distributed tracing enabled by default
0fd7bc4
@iamemilio
fix(go logs in context): dont make users generate their own timestamp…
a597ab7 
…s for go logs in context
@iamemilio
fix: remove zerolog specific config option from go agent docs
9180220 
The user experience was changed to remove the zerolog config option. The
functionality has not changed, but overall the user experience is more
consistent this way.
@barbnewrelic barbnewrelic changed the title golang logs in context (Publish on Monday, June 27th) golang logs in context (ETA 06-29-22) Jun 24, 2022
barbnewrelic
barbnewrelic approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing these docs for launch!

@barbnewrelic barbnewrelic merged commit afde839 into newrelic:develop Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbnewrelic barbnewrelic barbnewrelic approved these changes

Assignees

@barbnewrelic barbnewrelic

Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Scheduled work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamemilio @barbnewrelic