Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8sDocs): clarify controlPlane monitoring #8075

Merged
merged 1 commit into from
Jun 22, 2022
Merged

feat(k8sDocs): clarify controlPlane monitoring #8075

merged 1 commit into from
Jun 22, 2022

Conversation

paologallinaharbur
Copy link
Member

Related to newrelic/nri-kubernetes#478 but still not closing it

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 16, 2022
@github-actions
Copy link

Hi @paologallinaharbur 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 16, 2022 •
edited

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 24m

barbnewrelic
barbnewrelic previously approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These edits look good to me!

@barbnewrelic
Copy link
Contributor

@paologallinaharbur I see that you mentioned this is related to another issue. OK for me to go ahead and merge this, or did you want to wait until your issue is also ready to close. Thanks for confirming either way! No rush.

@barbnewrelic barbnewrelic moved this from Hero to triage to In review in Docs PRs and Issues Jun 16, 2022
@barbnewrelic barbnewrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) pg_observability labels Jun 16, 2022
@barbnewrelic barbnewrelic self-assigned this Jun 16, 2022
@paologallinaharbur
Copy link
Member Author

Hello, I was planning to open separate PRs to make the review process as easy as possible. Therefore you can merge it :)

@barbnewrelic barbnewrelic merged commit b87e59c into newrelic:develop Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbnewrelic barbnewrelic barbnewrelic left review comments

Assignees

@barbnewrelic barbnewrelic

Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paologallinaharbur @barbnewrelic