Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Java): Restores the old generic Java install doc #8146

Merged
merged 5 commits into from Jun 23, 2022

Conversation

paperclypse
Copy link
Contributor

I didn't realize the old generic Java installation doc had some content that wasn't anywhere else. I've restored it and added a bit of extra context for why someone might want to read it.

@paperclypse paperclypse self-assigned this Jun 22, 2022
@github-actions
Copy link

Hi @paperclypse 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 22, 2022
@paperclypse paperclypse added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jun 22, 2022
@paperclypse paperclypse moved this from Hero to triage to Needs review in Docs PRs and Issues Jun 22, 2022
@bradleycamacho bradleycamacho self-requested a review June 22, 2022 17:01
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 22, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 23m

@paperclypse
Copy link
Contributor Author

Got an approving review, so I'm merging it in.

barbnewrelic
barbnewrelic previously approved these changes Jun 22, 2022
Copy link
Contributor

@barbnewrelic barbnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do what you wish with my review comments, then feel free to merge. No need for me to review again!

@barbnewrelic
Copy link
Contributor

@paperclypse Apologies, I saw this in the Needs Review column and did not notice that @bradleycamacho had self-assigned.

@barbnewrelic barbnewrelic moved this from Needs review to Waiting on TW to merge in Docs PRs and Issues Jun 22, 2022
@paperclypse
Copy link
Contributor Author

@barbnewrelic Thanks for your feedback! You highlighted some helpful things!

@paperclypse paperclypse merged commit 700fd62 into develop Jun 23, 2022
@paperclypse paperclypse deleted the restore-old-java-install branch June 23, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Development

Successfully merging this pull request may close these issues.

None yet

3 participants